Hi all, On Sat, Jan 16, 2016 at 10:40 AM, Andrea Faulds <a...@ajf.me> wrote: > > Thomas Punt wrote: >> >> Hi internals! >> >> Voting has opened for the inclusion of a digit separator in PHP[1]. Voting >> ends in >> one week's time on January 20th. >> >> Thanks, >> Tom >> >> [1]: http://wiki.php.net/rfc/number_format_separator >> > > Initially I was going to abstain from this vote, but I've changed my mind > and I am now voting in favour of the RFC. > > When choosing whether to add features to the language, we must set a high > standard, because every new additions means additional complexity and more > knowledge PHP developers have to have. So, every new addition should be made > to fit well with existing features, be useful, and > > This feature offers some benefit in some cases. It doesn't introduce much > new complexity. There's no new syntax or tokens, it just modifies the form > of the existing number tokens. It fits in well what's already there, > consistently applying to all number literals. It follows established > convention in other languages. Its appearance at least hints that values > with these seperators are not constants or identifiers, but numbers, > reducing potential for confusion. It limits its own application to prevent > abuse (no leading, trailing, or repeated separators). And it's relatively > intuitive. > > So I think it might be worth adding, thus my vote. Though we must be > conservative with additions, this one doesn't seem to be too problematic. > > That said, I might be voting the wrong way. The feature does seem to have > limited applicability. That's really the only thing I can say against it.
The same opinion. The syntax is popular enough and doesn't add much complexity, but it seems this RFC wouldn't pass. Large numeric literals are not used often. However if it is used, it's frustrating to read. e.g. Code audit/review. Why not make computer do the job? I hope more people change their mind. Regards, -- Yasuo Ohgaki yohg...@ohgaki.net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
