On 04/01/2016 17:12, Andrea Faulds wrote:
Hi Mark,
Mark Baker wrote:
I'd like to suggest a couple of additional options for the round()
function, two new flags for PHP_ROUND_UP and PHP_ROUND_DOWN; which are
similar to the existing ceil() and floor() functions, but allow a
precision argument as well.
The PR is at https://github.com/php/php-src/pull/1658
This seems like a sensible addition. That said, I'm not sure about
those names, I think they might get confused with
PHP_ROUND_HALF_UP/DOWN. Perhaps name them PHP_ROUND_CEIL and
PHP_ROUND_FLOOR, or so? Or PHP_ROUND_ALWAYS_UP/DOWN?
Thanks for the feedback.
I see where you're coming from, though I'd chosen to use
PHP_ROUND_UP/DOWN precisely because of the two existing constants
PHP_ROUND_HALF_UP/DOWN to provide a degree of naming consistency. That
being said, it's simple enough to change the names of new flag
constants; but I'll wait a couple of days to see if anybody else weighs
in with an opinion before updating the PR.
--
Mark Baker
_________
|. \ \-3
|_J_/ PHP |
|| | __ |
|| |m| |m|
I LOVE PHP
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
