On 1 January 2016 at 12:12, Bishop Bettini <bis...@php.net> wrote: > On Fri, Jan 1, 2016 at 2:53 PM, John Bafford <jbaff...@zort.net> wrote: >> I think when I brought this up before, the major open discussion point >> before the thread died was what period of time constituted long enough for >> closing a waiting-on-submitter PR. 2 weeks is probably too short, but it >> seemed a reasonable minimum and something had to go into the RFC. I think 4 >> weeks is probably a better place to start. >> > > Warn at 2 weeks, close at 4? There's no real harm in closing it unmerged: > the submitter can always resubmit.
This is a contribution from the cheap seats, since I don't have time to actually help, but I'm not a big fan of auto-closing contributions (at least until the branch is literally closed for bug fixes). I'm worried that it'll send a message that we don't really care about getting outside contributions, which is obviously not the case. What's the argument for auto-closing? Our stable branches are actually pretty stable, so fixes and small features aren't generally going to have merge issues that fast. Adam, who misses the days when he could read every new bug and comment. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
