On Wed, Nov 4, 2015 at 4:28 AM, Côme Chilliet <c...@opensides.be> wrote:
> Le mardi 3 novembre 2015, 18:59:42 Andrea Faulds a écrit : > > I'd argue this is a regression, documented feature or not. Supporting > > 'host:port' is not a bug, and this has broken existing code, which micro > > (x.y.Z) versions are not allowed to do. It should be fixed ASAP. > > So I got two votes against and one for putting host:port back. > > I feel bad about pissing off users that used host:port, but it does seems > safer to require the scheme. > > Detecting the host:port syntax only to show a warning seems tedious. It’s > like saying to the user «I get what you want me to do, but I won’t do it». > > And the point that it’s already been gone since a few version anyway is > also a good point, people would have a code that works on some versions and > not others, let’s save them the nightmare. > > After reading the reactions on the bug tickets related to this problem, it > seems users are understanding the change and adapting without problem, so > I’m for fixing the documentation on this one. Discussing the details on a > separate email. > > MCMic > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > I would keep the old behavior for 5.6, even if that was unintended nobody complained about it(so removing it isn't a bugfix per se), so I see no reason to break userland code working before in a micro version. for PHP-7.0 we can remove the old undocumented behavior but drop a mention in NEWS/upgrading. -- Ferenc Kovács @Tyr43l - http://tyrael.hu
