Hi Andrea, On Oct 28, 2015 9:06 PM, "Andrea Faulds" <a...@ajf.me> wrote: > > Hi Dmitry, > > > Dmitry Stogov wrote: >> >> Please take a look: https://github.com/php/php-src/pull/1604 >> The speed improvement on real-life is insignificant. >> VM size is increased by 10KB. >> >> I don't have a strong opinion, if this should go into master or not. > > > 10KB VM size increase for insignificant real-life improvement doesn't sound good. Surely that would hurt performance on some systems?
Of corse, this may affect performance in negative way. This occurs, mainly not becuae differenf code size, but because of different code layout. The same change may affect performance in different ways on diferent systems. Anyway, this patch is not only for speed, but for clenup and making difference, between regular variables and static properties. We will try to reduce the VM code size later. Thanks. Dmitry. > > Thanks. > > -- > Andrea Faulds > http://ajf.me/ > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >
