Hi Jakub, > -----Original Message----- > From: jakub....@gmail.com [mailto:jakub....@gmail.com] On Behalf Of Jakub > Zelenka > Sent: Tuesday, August 25, 2015 2:46 PM > To: Anatol Belski <anatol....@belski.net> > Cc: Dmitry Stogov <dmi...@zend.com>; Rowan Collins > <rowan.coll...@gmail.com>; PHP Internals <internals@lists.php.net> > Subject: Re: [PHP-DEV] Overflow checks and integral vars comparison > > Hi Anatol, > > On Tue, Aug 25, 2015 at 12:41 PM, Anatol Belski <anatol....@belski.net> > wrote: > > > Hi Dmitry, > > > > > -----Original Message----- > > > From: Dmitry Stogov [mailto:dmi...@zend.com] > > > Sent: Tuesday, August 25, 2015 9:29 AM > > > To: Anatol Belski <anatol....@belski.net> > > > Cc: Rowan Collins <rowan.coll...@gmail.com>; PHP Internals > > > <internals@lists.php.net> > > > Subject: Re: [PHP-DEV] Overflow checks and integral vars comparison > > > > > > Hi Anatol, > > > > > > I don't see any problem adding ZEND_LONG_INT_OVF and similar macros > > > into 7.0. > > > > > Thanks for taking a look. I was doing a quick RFC draft yesterday also > > including a ZPP suggestion from Jakub. But given there's some demand > > on such checks still, probably better I withdraw the RFC and work > > towards macros for the range checks and integrating them at the appropriate > places. > > Pure internal stuff anyway. > > > > > I think it makes sense to merge all macros without RFC to master for 7.0 and > keep RFC just for ZPP changes as there might be some discussion about the > names (e.g. "r" is already used for resources ;) ). Or maybe just check if > everyone > is ok with names (ZPP flags) and then integrate it as well. In any case, it > would be > nice to have this in ZPP at some point. > Yep, was just a quick writing yesterday, overseen the 'r'. Actually pity as it could be like 'q', 'r,', 's' ... easy to memorize :)
With ZPP there could be also a little performance concern, as it would add four cases to parse to ZPP yet. So probably also depends on which scale it is needed. And another point is that an implementation with the fast ZPP were needed as well. So turns out as a bit more than it looked at the start, but would be IMHO useful from the functional sight. I'd be working of the macros next days, to cover as much as possible then. Regards Anatol -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
