On Fri, Aug 21, 2015 at 8:02 PM, Bob Weinand <bobw...@hotmail.com> wrote:
> > Am 21.08.2015 um 15:58 schrieb Dennis Birkholz <den...@birkholz.biz>: > > > > Hi all, > > > > Am 21.08.2015 um 14:51 schrieb Christoph Becker: > >> Hi Bob! > >> > >> On 21.08.2015 at 00:13, Bob Weinand wrote: > >> > >>> Commit: 82b73fd1e3c53228bb31b75a446114b5fd0cd240 > >>> Author: Bob Weinand <bobw...@hotmail.com> Sun, 2 Nov 2014 > 23:25:49 +0100 > >>> Parents: a3eed5fbfe24368726906f425b15ce40b5fc36e0 > >>> Branches: master > >>> > >>> Link: > http://git.php.net/?p=php-src.git;a=commitdiff;h=82b73fd1e3c53228bb31b75a446114b5fd0cd240 > >>> > >>> Log: > >>> Remove assumption that extensions are in ext/ext-name > >>> Fixes also a weird ln (symlink) hack for phpdbg > >>> > >>> Changed paths: > >>> M acinclude.m4 > >>> M build/config-stubs > >>> M build/genif.sh > >>> M build/order_by_dep.awk > >>> M configure.in > >>> M sapi/phpdbg/config.m4 > >>> > >>> > >>> diff --git a/build/genif.sh b/build/genif.sh > >>> index 14e19b7..2ca2e6d 100644 > >>> --- a/build/genif.sh > >>> +++ b/build/genif.sh > >>> @@ -24,7 +24,8 @@ cd $srcdir > >>> module_ptrs="$extra_module_ptrs`echo $@ | $awk -f > ./build/order_by_dep.awk`" > >>> > >>> for ext in ${1+"$@"} ; do > >>> - header_list="$header_list ext/$ext/*.h*" > >>> + ext_dir="$( cut -d ';' -f 2 <<< "$ext" )" > >>> + header_list="$header_list $ext_dir/*.h*" > >>> done > >> > >> It seems this change breaks ./configure on some systems. On a Debian > >> Jessie box I get: > >> > >> creating main/internal_functions.c > >> ./build/genif.sh: 27: ./build/genif.sh: Syntax error: redirection > >> unexpected > >> creating main/internal_functions_cli.c > >> ./build/genif.sh: 27: ./build/genif.sh: Syntax error: redirection > >> unexpected > >> > >> Same problem on Travis, e.g. > >> <https://travis-ci.org/php/php-src/jobs/76612894>. > >> > >> Could you please have a look at this issue? > > > > the problem is the $(), which is only supported if bash provides > > /bin/sh. In debian the default shell is dash so $() does not work. You > > should replace it with backticks to make it more portable. > > > > Greets > > Dennis > > Thanks, > > but looks like Ferenc was faster than me :-) > > yeah, and Anatol beat me to fix the here string :) -- Ferenc Kovács @Tyr43l - http://tyrael.hu
