Hi!

Some suspicious use of spl_object_hash() out there...

> https://github.com/symfony/symfony/blob/master/src/Symfony/Component/VarDumper/Cloner/VarCloner.php

Not sure what this one does... but calculations with spl_object_hash()
look very suspicious.

> 
> https://github.com/horde/horde/blob/master/imp/lib/Factory/MimeViewer.php
> 

This one _might_ be doing it right, but not sure as basing caching
instances on hash of a (mutable) object may produce weird results.

> https://github.com/horde/horde/blob/master/framework/Support/lib/Horde/Support/Randomid.php

Oh wow, what's going on there? That's obviously not a proper use of
spl_object_hash().

> 
> https://github.com/WordPress/WordPress/blob/master/wp-includes/plugin.php

I guess this one is wrong too, as it mentions storage, and storing
object ID is pointless. Maybe I am misunderstanding what "storage" means
there.


-- 
Stas Malyshev
smalys...@gmail.com

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to