Hi Christoph, > -----Original Message----- > From: Christoph Becker [mailto:cmbecke...@gmx.de] > Sent: Monday, July 27, 2015 12:06 AM > To: Anatol Belski <anatol....@belski.net>; 'Pierre Joye' > <pierre....@gmail.com> > Cc: 'PHP internals' <internals@lists.php.net> > Subject: Re: [PHP-DEV] PCRE JIT stack size limit > > Definitely interesting ideas. However, currently I'm leaning towards a full- > fledged solution in PHP 7.1 (whatever that may be), and to only add the error > constant for PHP 7.0. Users can set pcre.jit=0 in php.ini and not change the > setting during runtime, if necessary. > > FWIW, some hours ago I've implemented the clean whole cache solution: > <https://github.com/cmb69/php- > src/commit/c41d78046da48db2fa8f5bd82fd6ac58099288f8>. > I wrote this script to test it https://gist.github.com/weltling/cd7f8127378989cca87c , but as expected - cache reset make a significant impact when the cache is full. Though, maybe as it's an exceptional situation, it were the simplest solution. Because it does not affect the normal usage, maybe it's ok for 7.0. Maybe we should give this flexibility, still in doubt. But the constant IMHO should be done anyway.
> >>> Running for the INI option and some custom JIT stack functionality > >>> needs > >> more brainstorming and test. Please ping when you have an initial > >> implementation, I'd be glad to help testing, etc. anyway. > >> > >> All in all it seems that we probably should have an RFC for that. > >> I'll consider to write one, but there's no need to hurry – too late > >> for 7.0 anyway. :) > >> > > Yep, the whole needs a good consideration about how to do it best > > without a big impact on the user side. Also probably it could be worth > > it to check how PCRE2 behaves in this cases, maybe it were worthwhile to > upgrade to PCRE2 for 7.1. > > Indeed, offering support for PCRE2 should be considered for 7.1. And also > support of the JIT fast path API: > <http://www.pcre.org/original/doc/html/pcrejit.html#SEC11>. > Yes, maybe we'll have to support both for a while because PCRE2 is quite new so it'll need quite some time distros catch up. Thanks Anatol -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
