Hi, > -----Original Message----- > From: Ferenc Kovacs [mailto:tyr...@gmail.com] > Sent: Sunday, July 5, 2015 7:02 PM > To: Sherif Ramadan > Cc: Dan Ackroyd; Jakub Kubíček; Dmitry Stogov; Bob Weinand; Andrea Faulds; > PHP Internals; Nikita Popov; Aaron Piotrowski; Levi Morrison > Subject: Re: [PHP-DEV] Re: Revert unapproved language change, was: Fix > division by zero to throw exception (round 2) > > On Sun, Jul 5, 2015 at 1:01 PM, Sherif Ramadan <theanomaly...@gmail.com> > wrote: > > > On Sun, Jul 5, 2015 at 6:29 AM, Dan Ackroyd <dan...@basereality.com> > > wrote: > > > > > On 4 July 2015 at 20:56, Sherif Ramadan <theanomaly...@gmail.com> > wrote: > > > > > > > > I'm proposing that we reconsider removing the warning from > > > > floating > > point > > > > division and here's why. > > > > > > Wait ....what? I don't remember an RFC about the behaviour changing. > > > Did someone ninja commit a change to the language? > > > > > > Well it sure looks like it: > > > > > > > > https://github.com/php/php- > src/commit/f9724b93f6592d2f77fa9165038a0ba0 > > db3da0c6 > > > > > > This is absolutely a change that needs an RFC. As the change was > > > done without one, please can it be reverted until an RFC is done? > > > > > > > I actually fully agree to the IEEE 754 compliance part and I doubt > > anyone will disagree on that part as it only stands to benefit > > everyone. However, I completely disagree with removing the warning > > blind-sidedly and especially two days before the beta1 release like > > that. I do opt that it be reverted, however, until the matter is fully > > resolved. If that happens to take a day or a month it shouldn't result > > in releasing ad hoc changes that will be wish-washy between releases > > like that should something change. At the very least let's cherry pick > > it out of the beta 1 release to ensure we've fully resolved the matter. > > > > > hi, > > my 2 cents: > the IEEE 754 related changes had enough discussion and while it would have > been nice handling it under an rfc earlier instead of pushing it late calling > it a > bugfix I think we should keep it. > however I see little point in removing the warning at this point, I can > understand > how from a purist point of view it makes little sense, but we have this > warning > forever and as people already pointed out at the very least can help with > debugging bugs in your code. > so I would keep the warning for 7.0 (as removing it after beta1 would be even > worse than pushing the change 2 days before tagging beta1). > The related changes are reverted as breaching BC. The issue reported by Dan is likely to prevent people from catching errors the ways they do it in PHP5. Furthermore, it's likely to break apps or make them misbehave. This is something we can't bear so short before beta1.
Bob, I would kindly ask you again to not to commit such controversial changes without having a clear OK from the community. As for me - IMHO, the proper solution could be your first commit introducing exceptions for all (as in many other programming languages for div by zero) - but it was a BC breach as well, timed too short before feature freeze. So it is something that clearly needs an RFC to evaluate any possible risks and to make an informed collective decision. Many things are not perfect yet even in PHP7, but we have our timeline plan on which you was voting, too. Thanks Anatol -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
