On Mon, Jun 22, 2015 at 5:23 PM, Rasmus Lerdorf <ras...@lerdorf.com> wrote:
> On 06/22/2015 05:11 AM, Dmitry Stogov wrote:
> > Hi Rasmus,
> >
> > Your latest changes broke more than 100 tests.
> > Sorry, but I had to revert your commits and related Bob's fixes.
> > You may find them in internal-arg-info branch.
> >
> > Please, don't do experiments on the common code base at beta stage.
> > On the other hand, I don't see a big problem committing this, when a
> > complete solution is ready.
>
> Oops, way more test failures than I expected. But I don't understand
> some of them. For example, Zend/tests/constants_008.phpt which is:
>
> <?php
> define('a', 2);
> const a = 1;
> if (defined('a')) {
> print a;
> }
>
> With arginfo filled in correctly for define() and defined() the output is:
>
> ../../sapi/cli/php -derror_reporting=-1 constants_008.php
> Notice: Constant a already defined in Zend/tests/constants_008.php on line
> 4
> 1
>
> And without arginfo:
>
> php -derror_reporting=-1 constants_008.php
> Notice: Constant a already defined in Zend/tests/constants_008.php on line
> 4
> 2
>
> I wasn't expecting fixing arginfo would change how constants behave.
>
Actually, when you added type hints, php compiler stopped optimizing and
using ZEND_DEFINED (and others) instead of internal function calls, but of
course this shouldn't change behavior. I'll need to take a look into
difference.
Thanks. Dmitry.
>
> -Rasmus
>
>
