On Tue, Jun 9, 2015 at 9:13 PM, Levi Morrison <le...@php.net> wrote: > On Tue, Jun 9, 2015 at 11:40 AM, Aaron Piotrowski <aa...@icicle.io> wrote: > > Does anyone have any questions, comments, or concerns about the > Throwable Interface RFC? > > > > http://wiki.php.net/rfc/throwable-interface > > > > The proposed exception hierarchy: > > > > interface Throwable > > ⊢ Exception implements Throwable > > ∟ Error implements Throwable (replaces EngineException) > > ⊢ TypeError (replaces TypeException) > > ∟ ParseError (replaces ParseException) > > > > I’d like to complete a vote before too many alpha releases are made. > > > > I’ll be happy to resolve the merge conflicts in the PR if the vote > passes. > > My only objections have already been raised, but I'll reiterate them > briefly: > > 1. Having both Error and Exception makes little sense, especially > since we have historically used error to refer to an error that wasn't > an exception (something that triggered the error handler). > 2. The name "Error" is going to have a fairly high collision rate > with user code. >
I also like EngineException more than Error. > 3. I think they should all use Exception as the root instead having > a new root with multiple children (and yes, I am aware of the impact > of this, and it has already been discussed on this list). > This done on purpose. To prevent catching of new exceptions by old PHP code. If we won't accept this now (before 7.0 release), it would make more troubles in the future. I didn't make deep code review, and don't know all possible consequences. Anyway, I would make a chance to accept this now or never. RM, your thoughts? In case we decide to vote for this RFC, I'll make code review and will help with possible problems. Thanks. Dmitry. > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >
