Hi! > It seems to me we are mixing two questions : can 'small > self-contained' changes be introduced in a patch release, and how > 'small' and 'self-contained' a change must be not to require an RFC ? > It seems implicit that, once an RFC is written, it is not a 'small > self-contained' change anymore.
Having RFC is not related to change being self-contained, but rather with if the change is obvious or needs more thorough discussion. *Usually* the latter would also not be small, but not in every case. On the other hand, the change may be needing thorough discussion, but when the discussion has been done, the code change itself may be tiny and self-contained. So it's not the same. > One example : https://wiki.php.net/rfc/cyclic-replace can probably be > considered as a 'small self-contained' addition. Should I continue > with the RFC, respecting feature freeze and proposing it for 7.1, or > should I just ask the PR to be merged in 7.0 ? If it is accepted by a > vote, can it still go to 7.0 ? It is really not clear to me. This RFC seems to request a change in functionality of existing function, which already does something (albeit not very useful thing). This doesn't look like self-contained change to me. -- Stas Malyshev smalys...@gmail.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
