On Mon, March 16, 2015 18:17, Dmitry Stogov wrote: > If I see the results properly, it makes bout 5% improvement. Right? > Definitly makes sense to commit. > Let me know when you finish testing, or like me to commif this as is. > I've just pushed your patch along with some tests I did to ensure functionality. The tests are not narrowed to Windows, so this should help for the further development.
With the perf - yeah, about 5% speedup is like the best time I saw during the perf test. Previously execute_ex was checking for EG(timed_out) on every possible iteration even though it didn't always need it. Now only the relevant opcode handlers are involved in this check, which tells that difference. Despite a thorough testing, it still can be that the EG(timed_out) check is missing somewhere, so anyone seeing it please report. Thanks. Anatol -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
