On 16/02/15 15:31, François Laupretre wrote: >> - There is a lack of expertise at the core level of the code, so >> > collaboration on each feature is low. RFCs tend to have a single >> > sponsor, who has to see the whole process through to the end. > - One thing we can encourage, while indirect in this case, is writing more > comments in code. With PHP 7, Sara's book is almost unusable and nobody will > write another one soon. 'UPGRADING' and friends are fine but far from > sufficient, especially for newcomers. The only solution I imagine is adding > comments in the code. I know it is annoying when you don't have much time, > but comments can be improved at any time. They can be written by the feature > author, but also by other people, who needed a (too) long time to understand > a feature, and write explanations to help followers. As an example, I spent > some time understanding the multi-level architecture of str_[i]replace > functions and added a lot of comments along with the patch I will propose. > Actually, everywhere you spend time understanding what's going on, more > comments are needed. That's really important because, today, the code > contains almost no comments except function prototypes. That’s ant work and I > am far from perfect about comments in my own code, but it can make a difference, especially making the project more attractive for newcomers (and we *need* new blood).
Having been expanding docblock annotation in production code for many years many of the current discussions cause me a number of problems with the move to change just how we document in production. I've been back inside the code again simply trying to keep my own KEY elements available and it really does take a long time to understand some of the way the code is currently structured. The phpng changes seem to be tied up with a number changes to style of things rather than implementing the change, but it *IS* only the person who developed the change that can totally understand how to change every other extension in the same style :( Currently I lost track of the bits I should be using as current notes and searching just pulls up phpng or even older guides, so it would be nice to have a single index for PHP7 with all of the good samples linked. Oh and currently I can't even get master to compile ... which it was doing here Friday ... -- Lester Caine - G8HFL ----------------------------- Contact - http://lsces.co.uk/wiki/?page=contact L.S.Caine Electronic Services - http://lsces.co.uk EnquirySolve - http://enquirysolve.com/ Model Engineers Digital Workshop - http://medw.co.uk Rainbow Digital Media - http://rainbowdigitalmedia.co.uk -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
