Hi, > On 15 Feb 2015, at 12:39, Xinchen Hui <larue...@php.net> wrote: > > On Sun, Feb 15, 2015 at 10:46 AM, Andrea Faulds <a...@ajf.me> wrote: >> Hi everyone, >> >> I should’ve done this a long time ago, but I’m going to hold a vote on this >> RFC. The implementation isn’t finished, but the remaining work isn’t >> impossible to surmount (though help would certainly be appreciated). RFCs >> can be put to vote without implementations (or so says >> https://wiki.php.net/rfc/howto), so the fact the implementation is >> unfinished isn’t necessarily a blocker. > for such a big change, the implementation self is also important, > there was some RFC accepted with "not good" implementation, which > cause lots of troubles for us to maintaining .
This vote isn’t to be thought of as accepting the implementation, merely the feature. If the implementation isn’t good enough, the feature could actually be dropped for PHP 7, as much as I hope that won’t happen. >> >> Putting it to a vote, finally, means I can stimulate further discussion >> (let’s face it, most discussion on a given RFC happens during voting), and >> importantly, see how much support the RFC has in order motivate myself to >> finish the implementation. >> >> I think this would be a useful feature for PHP. It brings PHP into line with >> other modern dynamic languages in having integers of arbitrary size. It >> makes integer behaviour both more intuitive and more consistent across >> platforms. It (finally) adds a means for handling of 64-bit (and larger) >> integers in 32-bit environments. I think allowing integers to grow as needed >> and not having to worry about platform-specific details is very “PHP”, as >> well. >> > from your RFC: > " > but obviously the implementations of anything dealing with integers > may need to be changed." > > this sounds too much compare to the benefits it brings.. (User can use > bcmath or other similar thing to deal with big int). It’s not a massive change. All the places in core have already been changed. Most extensions taking integers do so via zpp’s “l” type (or FAST_ZPP’s Z_PARAM_LONG), which handles bigints properly. The main issue is functions accepting zvals (“z” or Z_PARAM_ZVAL). In such cases, the change is usually two lines of code to add an IS_BIGINT case to a switch. > and actually, I'd prefer this to be a extension instead of get it into core.. > > too much changes for little gains.. > > Thus, I voted -1 on this. Alright, I can understand your perspective. -- Andrea Faulds http://ajf.me/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
