As much as I want scalar types I'm voting no as:
i) Having this code:
function foo(int $numberOfRightTurns) {
$x = $numberOfRightTurns * 90;
return sin(deg2rad($x))
}
work or blow up depending on a setting at the top of the file is horrible.
ii) Having the code that I write in userland behave differently
depending on how people call it, is also horrible.
Additionally Andrea, I am disappointed that you opened voting without
a option with the 'declare' stuff removed. This is despite myself
having asked you for an vote option for just strict types directly
several times. Other people have asked for a vote option that allows
strict and weak types with a different syntax.
I realise that the RFC as it stands is your preferred option, but just
not accepting feedback during an RFC is not appropriate.
I think it's clear that a lot of people want scalar types, so I hope
that we can get the implementation right, but this RFC isn't it.
cheers
Dan
On 5 February 2015 at 20:14, Andrea Faulds <a...@ajf.me> wrote:
> Good evening,
>
> At long last, I’m going to put the RFC to a vote. It’s been long enough - I
> don’t think there needs to be, or will be, much further discussion.
>
> I’d like to make sure that everyone voting understands the RFC fully. Please
> read the RFC in full: the details are important. And if anyone has any
> questions or uncertainties, please ask them before voting. I am very happy to
> answer them.
>
> I would urge everyone who wants type hints to vote for this RFC. It is not a
> perfect solution, but there can be no perfect solution to this issue.
> However, I think it is better than most of the alternatives suggested thus
> far - see the rationale section, and previous discussions. Crucially, this
> RFC would keep PHP a weakly-typed language, and not force either strict
> typing, nor weak typing, on anyone who does not want it. It would allow the
> addition of type hints to existing codebases. It would not create a situation
> where userland functions are strict yet internal functions are not, because
> the strict mode affects both. I’ve tested the implementation myself on my own
> code, and it worked well, providing benefits other proposals would not have
> given (see my previous post about my experiences).
>
> Voting starts today (2015-02-05) and ends in two weeks’ time (2015-02-19). In
> addition to the vote on the main RFC, there is also a vote on the type
> aliases issue, and a vote to reserve the type names for future RFCs’ sake if
> this RFC fails.
>
> The RFC can be found here, and it contains a voting widget:
> https://wiki.php.net/rfc/scalar_type_hints
>
> Thank you for your time.
>
> --
> Andrea Faulds
> http://ajf.me/
>
>
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
