No problem, I'll verify if (fix if necessary) and commit. Thanks. Dmitry. On Jan 28, 2015 5:37 AM, "Levi Morrison" <le...@php.net> wrote:
> Dmitry, > > I updated the patch to latest master and (seem to have) fixed a memory > issue with it. However when I pushed it back up Travis had a lot of failing > return types tests. Could you (and anyone else willing) pull it and see if > you are getting failing tests for release and debug builds? > > Cheers, > > Levi Morrison > > > On Tue, Jan 27, 2015 at 1:13 PM, Dmitry Stogov <dmi...@zend.com> wrote: > >> Hi Levi, >> >> Do you like me to make final check and merge your pull request? >> We need it :) >> >> Thanks. Dmitry. >> >> On Sat, Jan 24, 2015 at 8:01 AM, Levi Morrison <le...@php.net> wrote: >> >>> On Fri, Jan 23, 2015 at 5:06 PM, Levi Morrison <le...@php.net> wrote: >>> > As a reminder, this RFC (https://wiki.php.net/rfc/return_types) will >>> > close in a few hours. I want to thank everyone who has voted so far, >>> > and encourage anyone who has not yet voted to do so. >>> >>> I have close the voting. It has passed with a vote of 47 to 3. >>> >>> I will update the patch to the latest master and then ping Dmitry to >>> do a final pass before merging it into master. >>> >> >> >
