Hi Derick, On Wed, January 21, 2015 10:22, Derick Rethans wrote: > On Wed, 21 Jan 2015, Anatol Belski wrote: > > >> On Tue, January 20, 2015 22:08, Derick Rethans wrote: >> >>> >>> This commit makes timelib include a PHP specific file. timelib also >>> lives as an external library (https://github.com/derickr/timelib) and >>> is used by other projects. Because it's sort of an external library, >>> we can't include PHP's headers (php_stdint.h) in this case. >>> >>> How do you suppose we can fix this? Right now, I can't easily test >>> changes to the date/time parser (as they require *just* the lib). >>> >>> On Mon, 12 Aug 2013, Anatol Belski wrote: >>> >>> >>>> Commit: acea91b18c26149f753a037b96bed9e2b61bfdd1 >>>> Author: Anatol Belski <a...@php.net> Mon, 12 Aug 2013 >>>> > 13:39:17 > >>>> +0200 >>>> Parents: 52dac3e8cda94c8f38287ec3c437d9450b31b527 >>>> Branches: master >>>> >>>> >>>> Link: >>>> >>>> > http://git.php.net/?p=php-src.git;a=commitdiff;h=acea91b18c26149f753a03 > >>>> 7b96bed9e2b61bfdd1 >>>> >> >> I've just fixed here >> >> > http://git.php.net/?p=php-src.git;a=commitdiff;h=2f8d40ca79224900af6e93c8 > 7 > 63412204bbfb8fd > >> , please check. >> > > This looks fine - cheers. But I think it should also go to PHP 5.6? > I'll merge that later myself if you don't have the time. > > > cheers, Derick > I'll backport it to 5.6. Also would add the Pierre's suggestion so those defines are only used when it's not inside PHP, as under circumstances it could lead to different defines or conflicts. This is easy done through the timelib_config.h include as that file is already being generated by configure.
Cheers, Anatol -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
