> De : Pierre Joye [mailto:pierre....@gmail.com]

> Could you add tests please? A must before going any further :)

Three tests are included in the patch : one to check that phar uris are 
cacheable, one to check that plain files and 'file:' uris are cacheable, one to 
check that 'http' and 'https' uris are not cacheable.

An additional test should be added in the opcache tests dir to check that 
opcache is caching plain files, phar uris, but not other protocols. It is in my 
todo list, but I wanted your comments first, as it is more complex to implement.

> Please add the changes to UPGRADING.INTERNALS and UPGRADING as well.

Done

Regards

François


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to