I don't see technical problems with the patch. However, I also don't see any significant benefits. >From the user perspective it'll just change error messages and prevent "final final class" declarations.
Nikita, what do you think? Thanks. Dmitry. On Fri, Dec 5, 2014 at 8:18 PM, guilhermebla...@gmail.com < guilhermebla...@gmail.com> wrote: > Hi guys, > > I'd really appreciate some review around the before-mentioned PRs. I have > added a new one to the list now: > > - https://github.com/php/php-src/pull/937 > > This PR addresses the parsing support for traits to have "extends" and > "implements", as they are invalid. > > There's another one in the oven, which prevents extension developers to > create classes that extends traits or interfaces. > This is currently supported only for userland classes, but not for Zend > API. > > Cheers, > > On Wed, Dec 3, 2014 at 8:39 PM, guilhermebla...@gmail.com < > guilhermebla...@gmail.com> wrote: > > > > > > > On Wed, Dec 3, 2014 at 8:06 PM, Levi Morrison <le...@php.net> wrote: > > > >> The parser changes need to be careful reviewed; I don't have time at > >> the moment to verify it but I think you unintentionally allowed some > >> syntax's that shouldn't be valid because of the addition to > >> `inner_statement`. > >> > > > > Shouldn't. I broke down class_declaration_statement into 3 pieces: > > class_declaration_statement, interface_declaration_statement and > > trait_declaration_statement. > > At the end, all I've done is adding the other 2 new rules back to where > it > > was consumed. > > > > > >> > >> Maybe I just looked too quickly. In any case, parser changes should > >> always get several people reviewing them. > >> > > > > Agreed. =) > > > > -- > > Guilherme Blanco > > MSN: guilhermebla...@hotmail.com > > GTalk: guilhermeblanco > > Toronto - ON/Canada > > > > > > -- > Guilherme Blanco > MSN: guilhermebla...@hotmail.com > GTalk: guilhermeblanco > Toronto - ON/Canada >
