Hi! On 16 Sep 2014, at 01:42, Timm Friebe <p...@thekid.de> wrote:
> Hi everyone, > >> Timm Friebe <p...@thekid.de> hat am 16. August 2014 um 18:09 geschrieben: >> two weeks ago, the RFC `Catchable "Call to a member function bar() on a >> non-object"` was accepted by a vote. I don't have commit access to >> php-src/Zend, >> so I can't commit this myself. Back from my summer vacation, I thought I'd >> whip >> up this email (after bringing the pull request up-to-date and making it >> mergeable once again) and ask whether someone here can review[1] and then >> merge >> the PR https://github.com/php/php-src/pull/647? >> >> Thanks in advance! > > Any news on this? Is there anything left I need to do to get this merged? > Should > I apply for Zend/ karma? It’s been merged; due to my deceptive eyes and the similarity between the PR numbers (647 vs 847), I’ve merged 647 instead and then added the test cases that were written for 847. The end result should be the same and certainly all test cases passed (safe for those involving mysql tests); I’ll check the Travis results when they come back. My apologies on the somewhat messy push for this :( > > -Timm > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
