Hi Derick, Could you please take a look into these tests failures. I actually, think that the new behavior is right. Calls to parent::__constructor() shouldn't change value of already constructed $this.
The expectation of ext/data/tests/bug67118_2.phpt looks completely wrong. The actual output of ext/data/tests/bug67118.phpt seems right. I'm going to change expectation of these tests in master if you don't object. Thanks. Dmitry. ---------- Forwarded message ---------- From: Dmitry Stogov <dmi...@zend.com> Date: Mon, Aug 25, 2014 at 1:28 PM Subject: Re: date extension broken tests To: Lior Kaplan <lio...@zend.com> Cc: Anatol Belski <a...@php.net> Hi Lior, This is known phpng related problem described here https://wiki.php.net/phpng#known_problems Thanks. Dmitry. On Mon, Aug 25, 2014 at 1:09 PM, Lior Kaplan <lio...@zend.com> wrote: > Hi Anatol, > > It seems you've done some changes to the date extension recently, could > you take a look at these two failures. > > Dmitry - FYI in case it's phpng related. > > Bug #67118 crashes in DateTime when this used after failed __construct > [ext/date/tests/bug67118.phpt] > > Regression introduce in fix for Bug #67118 - Invalid code > [ext/date/tests/bug67118_2.phpt] > > > Kaplan >
