On Aug 21, 2014 8:05 PM, "Andrea Faulds" <a...@ajf.me> wrote: > > > On 21 Aug 2014, at 19:03, Pierre Joye <pierre....@gmail.com> wrote: > > > Now to be honest I would merge it right away. I do not see why we need to discuss that again. When I see how phpng got accepted without a word, time to stop arguing about such things. Merge and move back to code. If one thinks that one thing or another should be changed, in this patch or phpng, he will need to write a rfc (and not in 6 months :). > > This is a trivial name change. We have only once chance to get it right since the IS_* constants are used so, so widely. We should get it right now.
Then please do a rfc, but we are not going to rewamp the patch for the 6th time. It has been accepted and we have been more than cooperative. > > > Forgive me if I’m wrong, but wouldn’t changing the name again just be a simple matter of global find/replace? > > > > No, totally not :) > > Why wouldn’t it? Could you elaborate? I would instead to ask you to try to migrate a not so trivial extension :)
