On Wed, Aug 13, 2014 at 10:38 AM, Pierre Joye <pierre....@gmail.com> wrote:
> On Wed, Aug 13, 2014 at 9:47 AM, Ferenc Kovacs <tyr...@gmail.com> wrote: > > On Wed, Aug 6, 2014 at 6:38 AM, Sara Golemon <poll...@php.net> wrote: > > > >> https://wiki.php.net/rfc/switch.default.multiple > >> > >> 'Cause this code is silly (even if it had case blocks), but we allow it: > >> > >> switch ($expr) { > >> default: > >> notExecuted(); > >> break; > >> default: > >> executed(); > >> } > >> > >> -- > >> PHP Internals - PHP Runtime Development Mailing List > >> To unsubscribe, visit: http://www.php.net/unsub.php > >> > >> > > Hi, > > > > sorry to jump in this late, but I'm not sure that it is a good idea to > only > > reject the multiple default blocks but keep the ability to have the same > > case multiple times: > > http://3v4l.org/eZdPU > > in this regard I think the current status is more consistent as it would > > after merging this patch. > > and I also think that this isn't an important enough issue to warrant a > BC > > break (albeit this is the better kind of BC: probably doesn't effect too > > many people, and they will be clearly notified about the error at compile > > time) so I voted no based on this two thing. > > I have a mixed feeling too about doing this change in 5.x. Without > nitpicking, it is still a BC break. I also think that making PHP > somehow consistent, less confusing, etc. while working on the PHP > specs, we should really target php7 for any of these changes. > > As of the discussions about the discussion phase, what is one week > more anyway? Especially in summer when the lucky ones are in holidays? > ;) > > after re-reading my email, I realized that instead of "and I also think that this isn't an important enough issue to warrant a BC break" I wanted to say that and I also think that this isn't an important enough issue to warrant a BC break in a minor version -- Ferenc Kovács @Tyr43l - http://tyrael.hu