On Wed, Aug 6, 2014 at 5:50 PM, Ferenc Kovacs <tyr...@gmail.com> wrote:
> > > > On Wed, Aug 6, 2014 at 5:38 PM, Dan Ackroyd <dan...@basereality.com> > wrote: > >> Hi Zeev, >> >> >I have no problem with changing this >> >habit, but I do have an issue with changing it retroactively for a >> >particular vote. >> >> Agreed, changing rules retroactively is bad. Considering improving >> practices for the future is good. >> >> >To your specific feedback, there's a migration document to extensions >> linked >> >from the RFC, and shared here on internals about 10 days ago: >> >> Thanks for that document. >> >> It would also be really useful if you could add a link to two commits >> of a non-trivial extension that has been migrated, with one commit >> before, and one commit after the migration. That would allow people >> like myself who only rarely dip into PHP internals to see the >> differences actually applied to code. >> > > git diff origin/master.. -- ext/curl (for example) > is this really something which you think most voters would have trouble > doing? > > -- > Ferenc Kovács > @Tyr43l - http://tyrael.hu > git diff origin/master..origin/phpng -- ext/curl is slightly better as it works independently from the current checkout. -- Ferenc Kovács @Tyr43l - http://tyrael.hu
