On Tue, Aug 5, 2014 at 2:14 PM, Pascal Chevrel <pascal.chev...@free.fr> wrote:
> Le 05/08/2014 14:01, Pascal Chevrel a écrit : > > Le 05/08/2014 13:41, Dmitry Stogov a écrit : >> >>> Now it must be completely fixed in git. >>> >>> Thanks. Dmitry. >>> >>> >> Thanks Dmitry, will the .deb package be soon updated so as that I can >> test that the issue is resolved on my side? >> >> > Actually, shouldn't 'php -i' expose somewhere the php-src revision that > was used for compiling to make QA easier? (PHP in general, not a PHPNG > specific question) > > > Regards > > Pascal > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > compiling php from version control is for development purposes, so if somebody decides to ship binaries based on an untagged php version, it is his/her responsibility to provide a way for the end user to be able to figure out the exact version which was used for the build. the official php versions all use a separate version and even the http://snaps.php.net/ tarballs have a prise date in the filename to make it easier to tell which version was used as a basis (I think it would make sense to also add the git verion to the filename). I don't think that it would be a good idea to adjust our current build system to check if the build is done from git and patch the php version files on-the-fly so that the the resulting binary can tell which git version was used. -- Ferenc Kovács @Tyr43l - http://tyrael.hu
