On Tue, Jul 29, 2014 at 9:48 AM, Stas Malyshev <smalys...@sugarcrm.com> wrote:
> Hi! > > > What I found *not safe*, throwing unwanted warnings hitting an > > undesired behavior, or even segfaulting, and thus needing patch : > > - Dom > > - Mysqli > > - sqlite3 (sqlite3stmt class segfaults) > > I've fixed all the instances of problematic behavior with no ctor that I > could catch now. I could not reproduce problems in DOM or mysqli, so > it'd be nice to have reproductions there. Otherwise, I think the core > modules are fine in my tests. > Mmmm, I can't reproduce segfaults. I can only hit the check messages that check the instance is correctly constructed. When sqlite and SPL is patched, can we say we are safe about this issue ? For SPL, I have no deep knowledge about it, I couldn't find any bad behavior from my tests, all seemed to check the state, but I did not perform full 100% coverage tests. Thanks. Julien