Hi Stas,

On Sun, Aug 11, 2013 at 7:54 AM, Stas Malyshev <smalys...@sugarcrm.com>wrote:
>
>  >  - Session fails to save if it contains special chars
>
> Session data or session variable names? If the former, it is a strange
> bug but certainly needs fixing. If it's the latter, it is the same
> exotic issue, which I suspect very small number of people actually have.
> Still, I'm ok with adding option to support them, as long as it does not
> make problems for the majority.
>

IIRC. It is name.

 >  - Want unserialize session from session data, not from $_SESSION
> >  - Need function generates initial session data via dession_decode
>
> These functions can be added without changing session format, but the
> mere existence of these requests shows us that
>
> >  - Session should use plain serialize
>
> This is not a valid request, there's nothing mandating session using
> plain serialize.
>

This kind of request were closed as bogus/won't fix since there were
register_globals. We can make the serializer, but it's not worth it due
to the limitations at least for me.


>
> > We don't want to keep misdesigned component due to "register_globals",
> > don't we? Especially when the solution does not have real BC issue.
>
> We're walking in circles here. I have a number of times existence of the
> BC issue, yet you plainly dismiss it as "not real", and continue to talk
> about register_globals, which has nothing to do with it. So, to not
> prolong pointless discussion, here's my opinion:
> 1. Adding php_serializer option for session is fine for 5.5, please make
> a pull req for it.
> 2. Making it default - as long as it is not backwards-compatible - is
> not OK, at least before PHP 6. If you feel strongly that it must be
> done, the vote must be held on this subject since this change has BC
> implications.
>
> With this, I think I'm done discussing this subject.
>

OK. I'm fine with this, I'll send PR later with tests.
I still don't understand why we should care so much, instead of
removing "some error occurred in some file line 0", though.

Anyway, this would be end of discussion and I'm glad that
I can close some of bugs/requests assigned to me.

Regards,

--
Yasuo Ohgaki
yohg...@ohgaki.net

Reply via email to