Hi, On Mon, Aug 5, 2013 at 2:01 AM, Yasuo Ohgaki <yohg...@ohgaki.net> wrote:
> Thank you for noticing crash. Data can be null, so the fix is OK. > Removing the limitation that prohibits setting session ID is fine for me, > too. > > Please, apply your patch. I thought we were in agreement about doing this properly in PHP.next? My arguments against this version of the patch still stand: On Thu, Jun 27, 2013 at 11:51 AM, Yasuo Ohgaki <yohg...@ohgaki.net> wrote: > Hi Arpad, > > 2013/6/27 Arpad Ray <array...@gmail.com> > >> I see the strict mode check is now implemented in the handlers and not >> session.c, presumably to keep ABI, but this means code is duplicated and >> the setting only actually works if the handler supports it. It's >> unfortunate timing since 5.5 has just gone, but I think it would make much >> more sense to have a new function in the structure (as in your original >> patch) and do this only in PHP.next. >> >> Having such an ini setting which quietly fails if using an unsupported >> handler is not good. I guess you could keep a whitelist of supported >> handlers but that's also obviously far from ideal. >> > > Thank you for comment. > > There are plenty of time before 5.6 release, I would like to fix ps_module > API also. Current implementation requires ps_modules to access PS(id) to > prevent rare case of crash. I'll try to implement a little better API for > ps_modules. > Arpad
