Chris,

When `--enable-zstrlen` is not enabled, I disable s and p, and changed ZPP
>> to rase an E_ERROR on unknown parameter types. The E_ERROR change is not
>> intended to go into production, but instead just makes life A LOT easier
>> refactoring modules one at a time.
>>
>
> Can you elaborate on the "problem"?  Ideally the return type of s & p would
> be toggled by ZEND_USE_LEGACY_STRING_TYPES
>

The problem is that changing 's' from int to size_t can (and does) cause
segfaults.

We can have the discussion if 's' and 'p' should remain there (and if the
compile time option should be there) at merge time, but for now the switch
just makes life easier making the change. It wasn't designed for a
long-term switch...

Anthony

Reply via email to