2013/6/28 Tjerk Meesters <tjerk.meest...@gmail.com> > >> Adding E_WARNING is better than removing as a result discussion, IMO. >> > > Given the sizeable number of functions that don't raise warnings, should > this behaviour then be extended to those as well, e.g. base64_decode(), > mb_*()? > > Of course, doing so puts the onus on the developer to validate their > inputs first to prevent warnings, but personally I feel the gauge on > likelihood to user input exposure conflicts with consistency concerns. >
Not like function deals with internal data, function that is supposed to deal with external inputs is better if it returns FALSE without error. Since we don't want to handle attack/invalid inputs as errors always. One may treat invalid data as user mistake. It depends of use case of the specific function, if triggering error is better or not. Anyway, mixing them up for a function should not be done, IMHO. Regards, -- Yasuo Ohgaki yohg...@ohgaki.net
