To be fair, the overall limit is going to be 32 bit anyway (due to the use of int for string lengths)...
I'm working on a patch to replace all references of string sizes with size_t, but as you can imagine, it's going to take some time... Just throwing it out there that a better fix may be coming down the road anyway. I'll post on-list in the coming days about this... Anthony On Thu, Jun 27, 2013 at 5:47 PM, Yasuo Ohgaki <yohg...@ohgaki.net> wrote: > Hi > > Just a comment for the patch. > > 2013/6/27 Ralf Lang <l...@b1-systems.de> > > > Does anybody know of intricate reasons why the existing patch > > > > > > > https://bugs.php.net/patch-display.php?bug_id=44522&patch=uploads_larger_than_2g_HEAD_v2&revision=latest > > > > could not be included into php 5.5? > > > > It uses long instead of uint but it makes large files available only to > 64bit platforms. > > It should use off_t along with "#define _FILE_OFFSET_BITS 64", but I'm not > sure if this work under windows. There may be other places that data type > should be changed. It should be checked carefully, otherwise memory fault > may occur due to integer overflow. > > Regards, > > -- > Yasuo Ohgaki > yohg...@ohgaki.net >
