Johannes,
On Wed, Jun 19, 2013 at 2:43 PM, Johannes Schlüter <johan...@schlueters.de>wrote: > > > On Jun 19, 2013, at 19:46, Anthony Ferrara <ircmax...@gmail.com> wrote: > > 1. Technically, all we need to do is force GC_G(gc_enabled) = 0 in > > shutdown. But we could also use zend_alter_ini_entry which has the same > > effect. The question comes is there any reason to go through the overhead > > of altering the ini entry instead of the global directly? We do access > the > > global directly in other areas (but it's typically only set via ini)... > > If possible try to prevent users from shooting their feet by reenabling > via ini_set() or gc_collect_cycles() or such. Yeah, for that very reason I pushed it after the destructor functions. It could technically go down a step further below the output buffer as well, but I don't thing that's too necessary... Additionally, I have switched it to use the ini behavior setting... > > Additionally, considering that this does solve a segfault, is it worth > > nominating this for 5.3? Or is it too risky (or something else I'm > > missing)... > > See my previous mail to the list ... > That's why I actually called out 5.3 specifically. I'm not sold either way, but I can see why some would want to get this into the last release... And I could see why not... Thanks, Anthony
