Hi Nikita, I didn't get why do we need separate zend_std_compare() function. May be I just didn't look careful :)
It would be great to look into the patch between master and current of your branch. It would be more clear than internal patches. Thanks. Dmitry. On Mon, May 13, 2013 at 2:50 PM, Nikita Popov <nikita....@gmail.com> wrote: > On Mon, May 13, 2013 at 12:25 PM, Dmitry Stogov <dmi...@zend.com> wrote: > >> Would need an additional object handler though (as compare_objects >>> works only on objects, so it's currently not possible to support something >>> like $gmp == 0). >>> >> >> Or may be we may introduce additional opcode (or even pseudo-opcode) >> ZEND_CMP to do it in the same way. >> > I implemented it with a separate handler for now ( > https://github.com/nikic/php-src/commit/208442f84afd7ccd8e2dce8138c0950719a2e031), > but I'm also okay with moving it into do_operation. Not sure if it's a good > idea to add pseudo opcodes though. > > Nikita >
