I think the warning can stay as-is, __toString is not necessarily available so casting to string in all occasions is probably not what we want.
I'm glad somebody could take this over and provide a complete patch, thanks Nikita! On Tue, Feb 19, 2013 at 2:25 PM, Derick Rethans <der...@php.net> wrote: > On Tue, 19 Feb 2013, Nikita Popov wrote: > > > This RFC proposes to remove the type-restrictions on Iterator keys > > used in foreach: > > > > https://wiki.php.net/rfc/foreach-non-scalar-keys > > > > I took over Levi's RFC and added a patch for it. > > Under "Open Questions" you write: > > > What should be done with the keys that are valid in the iterator, but > not in > > the array? I think the best approach would be to just set the array keys > with > > the exact same semantics as PHP would do (i.e. with all casts and > warnings). > > Would __toString be called in case the key was an object? > > cheers, > Derick > > -- > http://derickrethans.nl | http://xdebug.org > Like Xdebug? Consider a donation: http://xdebug.org/donate.php > twitter: @derickr and @xdebug > Posted with an email client that doesn't mangle email: alpine > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Etienne Kneuss http://www.colder.ch
