And by tests I mean fixing all the old tests which use Exception::getTrace().
There is no need to write a new test(s).
Dne Sun, 06 Jan 2013 00:28:17 +0100 Jáchym Toušek <enu...@gmail.com> napsal(a):
Are you sure there should be the $options parameter? It would not save any
memory because the trace needs to be pregenerated regardless. Back compatibilty
clearly doesn't need to be that strict in this case because for example in case
of debug_backtrace function the 'object' fields where added in 5.1.1 (not in
5.1.0!) and were enabled by default (there wasn't even a way to disable them -
that came with 5.2.5).
With that in mind there is no need for the $options parameter in my opinon.
Which meens the only thing missing is the tests, right?
Dne Sat, 05 Jan 2013 23:30:55 +0100 Stas Malyshev <smalys...@sugarcrm.com>
napsal(a):
Hi!
I've looked into it and I'm not sure whether an option for getTrace
method is the best way to solve this. I mean the trace is created
along with the exception so it would have to be generated with the
object fields regardless and then filtered if the option is not set.
I think it would be better to add new PHP directive for this
(disabled by default for back compatibility).
No, I don't think it is a good idea. We have too many config directives
already, and behavior-modifying directives is really not a good idea,
since it is a global state with all its problems.
Also what do you mean by DEBUG_BACKTRACE_*?
Constants used for trace parameters.
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
