On Fri, Nov 16, 2012 at 6:10 AM, Ferenc Kovacs <tyr...@gmail.com> wrote: > > > > On Fri, Nov 16, 2012 at 3:31 AM, Sherif Ramadan <theanomaly...@gmail.com> > wrote: >> >> On Thu, Nov 15, 2012 at 8:26 PM, Philip Olson <phi...@roshambo.org> wrote: >> > Hello geeks, >> > >> > Why does PHP 5.5 remove the *_logo_* functions? Is this a security >> > related move? Shouldn't these emit E_DEPRECATED errors in 5.5? >> > >> > Regards, >> > Philip >> > >> > -- >> > PHP Internals - PHP Runtime Development Mailing List >> > To unsubscribe, visit: http://www.php.net/unsub.php >> > >> >> Because the guids were removed. They were replaced with data URIs. It >> would make sense if there was some function to expose those data URIs >> to user-land, in the same way that the *_guid functions did, but I >> guess there isn't. >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> > > it was removed when https://github.com/php/php-src/pull/132 got merged after > a brief vote on the internals mailing list. > see Stas concerns about reusing the same function names for getting the data > urls: http://www.mail-archive.com/internals@lists.php.net/msg59293.html > > -- > Ferenc Kovács > @Tyr43l - http://tyrael.hu
Obviously it doesn't make sense to use the same function names for the data uris, but why weren't new functions added to expose the data uris to userspace in the same way we used to expose the guids to userspace? It only seems to make sense that we'd continue to do that and it's such a simple fix to replace the functions with new ones. I honestly don't care too much about this particular feature myself, but it sounds pretty silly that this PR did not include the new functions for exposing the uris. My 0.00002 cents... -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
