hi Sara! On Tue, Oct 30, 2012 at 2:57 AM, Sara Golemon <poll...@php.net> wrote: > http://wiki.php.net/rfc/uconverter > > Discuss!
Nice job! Some comments, raw :) : - the UCNV prefix is not necessary, we are in the UConverter class already, I would simply use LATIN_1, or ILLEGAL for exampe. - It is OO, we should or could use exception. Warning are not nice to deal with and errors are quite common during conversion - I would add ERROR_ to the error related constants (UNASSIGNED & co), or? Some questions, is 'latin1' the same than const UCNV_LATIN_1? or is there any relation between the two? Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
