I have created a single build combining the Generator RFC and the property getter/setter RFC. On Windows, one of the Generator tests fails (tests\generators\clone_with_stack.phpt), but all pass on Linux. There are some regressions due to the branch not included many of the recent fixes for Windows. The PHP on Windows releases are now built with Profile-Guided-Optimization(PGO) which optimizes compiled code for better performance in frequently used blocks. I have also created a PGO build that combines both RFCs. It has the same pass rate as the first, non-PGO build of both RFCs. I have posted the binary builds, source code and output from run-test here: http://131.107.220.66/build/RFC/ Implementing both RFCs together along with PGO on Windows works well enough for both RFCs to be implemented in php-next. Cheers -Matt
> Date: Mon, 3 Sep 2012 09:52:10 +0200 > From: pierre....@gmail.com > To: der...@php.net > CC: smalys...@sugarcrm.com; glo...@nebm.ist.utl.pt; internals@lists.php.net; > nikita....@gmail.com > Subject: Re: [PHP-DEV] Re: [VOTE] Generators > > hi Derick, > > On Sun, Sep 2, 2012 at 7:10 PM, Derick Rethans <der...@php.net> wrote: > > On Sat, 1 Sep 2012, Stas Malyshev wrote: > > > >> > illegal state was written on the RFC when voting opened, and the RFC > >> > was accepted almost unanimously. As the proposal was accepted as > >> > such, I saw no valid reason not to merge. In fact, changing the > >> > proposal after it was voted on would be much more objectionable. > >> > >> I definitely did not agree to using exceptions, though I support the > >> rest of it. > > > > Same here. > > > >> I'm completely fine with merging it but just for the record I'd like > >> to note that accepting it doesn't mean we will not tweak it or change > >> some fine details of it - like how we handle some error situations. > > > > Right, so lets remove that exception throwing! > > Let clear that topic once and for all (almost) instead. > > I think some guidance to help to chose on a case by base whether > exceptions should be used or not. Let discussion that in the other > thread. > > Cheers, > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >
