Hi Anthony! On Thu, Jun 28, 2012 at 4:00 AM, Anthony Ferrara <ircmax...@gmail.com> wrote:
> Hrm. Well, then I guess I could re-implement against crypt internally. > That would take either a slight re-implementation of the crypt() > internals, or slight refactoring of the PHP_FUNCTION(crypt) function > to enable c calls to it (even if it's disabled). We would have to expose the crypt implementation, it is not the case right now. But you could still use it using func call. Let me know if you need to expose it and which parts, we will need to refactor it a bit (which should be a good thing to do anyway). > I don't like the concept of core functions disappearing if they are > not implemented. Well, that's the case for extensions altogether so... :) However if I remember correctly, I made crypt always available from php 5.3 and later, for all algorithms. >> E_WARNING - When supplied an incorrect number of arguments. >> E_WARNING - When supplied a non-string first parameter (password) I would not use warnings at all but return false on error. Maybe add an argument or a function to fetch the error messages. In case you call other PHP functions, you can push/pop the errors easily as well. Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
