Hi Nikita, yep, once you see tsrm_ls it's clear. Just wanted to mention it was tested on windows. ZTS is enabled by default there.
It compiles fine now :) but Zend\tests\generators\clone_with_stack.phpt fails on both TS and ZTS builds under win the diff looks like 001+ 001- string(10) "xxxxxxxxxx" and running that php file manually leads to crash and points me to the zend_execute.h at line 335. I didn't debug it in details but could do it later if you have no fail on nix. Cheers Anatoliy Am Mi, 20.06.2012, 21:36 schrieb Nikita Popov: > On Wed, Jun 20, 2012 at 5:25 PM, Anatoliy Belsky <a...@php.net> wrote: >> Hi Nikita, >> >> I've just tried to compile your generators branch on windows, the build >> is >> broken there. This are the relevant messages before the compilation >> bails >> out: >> >> c:\php-sdk\phpmaster\vc9\x86\nikic\zend\zend_execute.c(1543) : error >> C2065: 'tsrm_ls' : undeclared identifier >> c:\php-sdk\phpmaster\vc9\x86\nikic\zend\zend_execute.c(1543) : error >> C2065: 'tsrm_ls' : undeclared identifier >> c:\php-sdk\phpmaster\vc9\x86\nikic\zend\zend_execute.c(1550) : error >> C2065: 'tsrm_ls' : undeclared identifier >> NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio >> 9.0\VC\Bin\cl.exe"' : return code '0x2' >> Stop. > > Hey Anatoliy! > > Thanks for testing the patch :) > The errors aren't really Windows specific, they are there because I > forget to put a few TSRMLS_CC and TSRMLS_DC in the code ^^ (I usually > develop without --enable-maintainer-zts because it makes debugging > easier). > I now fixed the zts errors, so the build should work fine now :) > > Nikita > Those errors aren't Windows specific; they are there because I usually > develop without --enable-maintainer-zts > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
