hi Gustavo, Very nice job :)
The only thing I really dislike is the procedural API. The prefix "intlcal_" is not very nice, but what I really doubt is the usefulness of the procedural APIs for the Calendar resources. It makes little to no sense to have it as it brings nothing in comparison to the OO version. I know we could have it to be consistent with other part of the intl extension but ... Cheers, On Mon, Apr 2, 2012 at 10:35 AM, Gustavo Lopes <glo...@nebm.ist.utl.pt> wrote: > Hi > > I have exposed ICU's Calendar API to PHP via the intl extension. It allows > date calculations with Gregorian, Chinese, Coptic, Ethiopic, Hebrew, Indian, > Islamic (civil/religious), Japanese, Persian, Taiwan and Thai Buddhist > calendars. For a broader overview of its functionality, see: > > http://icu-project.org/apiref/icu4c/classCalendar.html > > I have committed already this change: > > https://github.com/php/php-src/commit/1c16c89b96bb4e02850b198b901feebdb8da2269 > > Traditionally, these kinds of additions to the intl extension (that mostly > exposed 1 to 1 the ICU API) have not been preceded (or even followed) by any > discussion; however, Stas expressed the opinion this is not a proper course > of action nowadays. > > Consequently, if anyone has any non-trivial substantive (as opposed to > procedural) concern with this change, I will revert the merge and submit an > RFC. > > -- > Gustavo Lopes > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
