On 9 March 2012 00:11, Remi Collet <r...@fedoraproject.org> wrote: > Le 08/03/2012 09:03, Michael Wallner a écrit : >> Sorry for the delay, but I already explained the issue in >> the bug report: https://bugs.php.net/bug.php?id=61291 > > Thanks, for the explanation.
I'm still concerned about the idea that the output of a hash function would change from one minor release to another, frankly, whether the old output was right or wrong. That seems like the sort of thing users would rely on being very, very stable. > But mhash_001.phpt and mhash_003.phpt should not fail > (if we want a great PHP with 0 test failed). > > As this tests seems to be old ones from old mhash extension, > they probably should be tagged as "expected failed" with a message such > as "Compatibility break with php < 5.4.0" Agreed. I'm happy to mark them as XFAIL if that's what's expected. Mike? Adam -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
