On Tue, 2011-12-06 at 17:59 +0800, Laruence wrote: > Hi: > I am not sure whether is okey to change the existing zbacktrace, > so I open a thread that let people know. > > after that I change the patch, add a new zbacktrace_ex. I think > this should be okey, so I commit it. :)
I don't see a reason for not changing zbacktrace. Only issue would be if it becomes really slow or such, besides that having more information is good! johannes > sorry & thanks > > On Tue, Dec 6, 2011 at 5:53 PM, Ferenc Kovacs <tyr...@gmail.com> wrote: > > Laruence, I think that there is no point opening a thread if you will go > > ahead and commit after waiting 3 hours and 0 replies. > > Or did I miss someting here? > > > > On Tue, Dec 6, 2011 at 10:51 AM, Laruence <larue...@php.net> wrote: > >> > >> Hi: > >> I update the patch, instead of change the behavior of zbacktrace, > >> I add a new one "zbacktrace_ex", > >> > >> I am going to commit it, if there comes some problems, then we > >> could revert or edit it. > >> > >> thanks > >> > >> On Tue, Dec 6, 2011 at 2:33 PM, Laruence <larue...@php.net> wrote: > >> > Hi: > >> > I am plan to commit a new change to 5.4-trunk/.gdbinit which can be > >> > found at http://pastebin.com/N6hTRMRA. > >> > > >> > after update, the zbacktrace will print arguments info: > >> > > >> > (gdb) zbacktrace > >> > [0x95dac5d8] sleep(long: 1000) /tmp/1.php:21 > >> > [0x95dac4b8] e(resource(#5)) /tmp/1.php:17 > >> > [0x95dac3e8] d(bool: true) /tmp/1.php:13 > >> > [0x95dac2f8] c(array(3)[0x95de78a0]) /tmp/1.php:10 > >> > [0x95dac1c8] b(object[0x95de5158]) /tmp/1.php:7 > >> > [0x95dac0e8] a(string(8): "laruence") /tmp/1.php:24 > >> > > >> > any objections? > >> > > >> > thanks > >> > -- > >> > Laruence Xinchen Hui > >> > http://www.laruence.com/ > >> > >> > >> > >> -- > >> Laruence Xinchen Hui > >> http://www.laruence.com/ > >> > >> -- > >> PHP Internals - PHP Runtime Development Mailing List > >> To unsubscribe, visit: http://www.php.net/unsub.php > >> > > > > > > > > -- > > Ferenc Kovács > > @Tyr43l - http://tyrael.hu > > > > -- > Laruence Xinchen Hui > http://www.laruence.com/ > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
