On 12/01/2011 02:38 AM, Yasuo Ohgaki wrote: > Hi Daniel, > > 2011/12/1 Daniel K. <d...@uw.no>: >> Yasuo Ohgaki wrote: >>> >>> I've made the patch for trunk. I checked by using session module >>> tests using valgrind. >>> >>> https://gist.github.com/1379668 >> >> >> As a general comment there seems to be lots of extra white space in the >> 'empty' lines of the patch. > > Spaces are left by my emacs. > I don't think there are many lines with extra spaces, but I'll check.
Please just tell your diff to ignore whitespace when you create the patch. It is annoying to have to sift through extra irrelevant lines. -Rasmus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php