On Thu, Nov 24, 2011 at 11:31 AM, Ford, Mike <m.f...@leedsmet.ac.uk> wrote:
> > -----Original Message----- > > From: Gustavo Lopes [mailto:glo...@nebm.ist.utl.pt] > > Sent: 23 November 2011 22:31 > > > > On Wed, 23 Nov 2011 21:06:09 -0000, Pierre Joye > > <pierre....@gmail.com> > > wrote: > > > > > The fact that we have reports here showing code not working > > anymore > > > because of this change tells me that it is a BC break. We can call > > it > > > a bug fix but it still breaks code out there for no real benefit > > but > > > edge case usages. We had this situation before, that does not help > > us. > > > > > > > I'd say for no benefit at all. Why would anyone ever want to take a > > string > > offset from a string that certainly has length 1? Except for taking > > satisfaction in this "improved consistency", I see absolutely no > > benefit. > > > > Up until now, it was deemed a useless but innocuous change. Now that > > we > > found it has pernicious side effects, we ought to revert it. > > That's exactly my take on it. As far as I can see, if 5.4 is released > with this "fix" in, it will effectively be rendered a non-upgradable-to > version for most big projects. > we yet to see such a project. for example the ZF testsuite was ran against the RC1, and didn't bumped into this. we also run the symfony2 testsuite on ci.qa.php.net and the test results seems to be consistent between 5.3, 5.4 and trunk http://ci.qa.php.net/view/php-userland/job/php-symfony2/362/testReport/? -- Ferenc Kovács @Tyr43l - http://tyrael.hu
