On 09/13/2011 12:25 PM, Nikita Popov wrote:
I changed my previous patch to an SVN patch, so it is easier to apply
and added another patch (the one called "tokenizer_patch_full.txt"),
which additionally fetches the rest into a T_INLINE_HTML. (The "_full"
patch thus contains both changes. I didn't know how I could separate
them.)
I haven't seen much "buy-in" about your email. You might want to wait
until after Beta and revisit the topic later. If you add some concise
explanation it would be easier for people to weigh the pros and cons,
see what breaks and what gets fixed etc.
Chris
Could somebody apply the patch or give me advice how to improve it, so
it can be applied?
Thanks.
On Tue, Sep 13, 2011 at 9:57 AM, Nicolas Grekas
<nicolas.grekas+...@gmail.com> wrote:
I just set up an PHP environment and wrote a proper patch (including test
changes) to make it collect the next three tokens. It's a git patch and I'm
not sure whether it's compatible with SVN patches. I would love it if this
would go into 5.4 before beta. I didn't know how one could fetch the rest
into T_INLINE_HTML, so I'm hoping on help here from someone who actually
knowns C there :)
I just reopened the bug and posted an excerpt of this discussion with your
patch :
https://bugs.php.net/bug.php?id=54089
Nicolas
--
Email: christopher.jo...@oracle.com
Tel: +1 650 506 8630
Blog: http://blogs.oracle.com/opal/
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
