Hi! On 9/4/11 10:59 AM, Pierre Joye wrote:
No, just like what I said for the is_a change, but it was acceptable for is_a, right? is_a actually broken many (many) apps and codes out there and it was easily identified, and it was even acceptable in a patch release. Go figure.
Please do not drag totally unrelated matters into the discussion. It serves absolutely no purpose.
Look at the history for the mysql's bugs, plenty of them, internally or in userland.
OK, look at them and? What you want me to see there?
Can you please, and seriously, that's my last attempt, read my answers and see what we actually test? I never claimed that nobody uses this behavior but I cannot find any code, app or framework failing with mysqlnd. Please find one and I will change my mind.
You said "I cannot find any code out there relying on this test case and I very much doubt there is any.". This means you're claiming we're testing behavior for which there's no code out there - if your guesses reflect the truth - that is using it. I think you're wrong but that's exactly what you said.
Btw, I have seen many totally pointless tests written for the sake of having a better code coverage while the code itself makes absolutely no sense or could even represent something that should not work this way in the 1st place.
It is true, but this test actually proved useful - it discovered difference in semantics between mysqlnd and libmysql, and in frequently used functions at that. Now we know it and we have to decide what to do with it. I hope once the weekend is over, mysqlnd maintainers would voice their opinions on the matter - e.g., should it work this way or not. That's exactly what I want to achieve.
-- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
