On Thu, Sep 1, 2011 at 10:54 PM, Hannes Magnusson <hannes.magnus...@gmail.com> wrote: > On Thu, Sep 1, 2011 at 20:58, Pierre Joye <pierre....@gmail.com> wrote: >> Please show me one system relying on it? 13 years old... >> > > Your own test box before Rasmus pointed it out to you when you where > changing the tests. > > Forcing people to upgrade this kind of software between bugfix > releases doesn't give us anything other then annoyed users. > > >> Even if the plan is to drop it in 5.4+ for now. > > Fair enough. > > >> And yes the diff in the messages make testing harder as it should be. Other >> would have noticed it already as many tests fail because of that. > > So it works just fine? There are no security or related bugs in the > older versions? Or even performance reasons? > > There is no reason for us to test error messages from third party > software, and it doesn't cost us any more work to support it.. > > -Hannes > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >
I'm not sure that I understand this correctly, so let me ask this: Pierre do you want to change this because of this two broken tests: http://news.php.net/php.internals/55048 ? AFAIK it isn't directly related to different versions of bison, but to this change in 5.4 : https://wiki.php.net/rfc/improved-parser-error-message and yes, this means that we have to support a diverging set of tests for those cases when the test depends on the parse error messages. I think it is safe to revert your changes for those two tests in the 5.3 branch. -- Ferenc Kovács @Tyr43l - http://tyrael.hu -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
